Pablo Galindo Salgado comments

Results 329 comments of


                                            Pablo Galindo Salgado

Implement PEP 799 – A dedicated profiling package for organizing Python profiling tools

> Maybe something closer to the nature that it records the function calls? `profiler.call` or `profiler.fee` or `profiler.function`? Sampling profiler does not give exact call counts for the program which...

Implement PEP 799 – A dedicated profiling package for organizing Python profiling tools

> I know docs are still pending, but a brief What's New would be useful at least for the alpha releases. There is already a preliminary one here: https://docs.python.org/3.15/whatsnew/3.15.html#high-frequency-statistical-sampling-profiler

gh-142654: show the clear error message when sampling on an unknown PID

@kemingy can you approach this similarly as https://github.com/python/cpython/pull/142592 ? The idea is to not show an ugly stack trace or difficult to understand messages like "Failed to find the PyRuntime...

gh-142654: show the clear error message when sampling on an unknown PID

We also need a test for this

gh-142654: show the clear error message when sampling on an unknown PID

Made some small fixes but great job @kemingy! Thanks for the PR :rocket:

GC in free-threaded build has problems with `Py_INCREF()`/`Py_DECREF()` in `tp_traverse` handlers

There are two things here to address: * Better documenting the current situation for all kinds of builds. * Try to be more resilient or maybe warn if any of...

GC in free-threaded build has problems with `Py_INCREF()`/`Py_DECREF()` in `tp_traverse` handlers

> I think we can make [`handle_resurrected_objects`](https://github.com/python/cpython/blob/297f2e093ec95800ae2184330b8408c875523467/Python/gc_free_threading.c#L974) more robust to this by splitting the first pass over `state->unreachable` into two passes. Can you elaborate on this to double check that...

GC in free-threaded build has problems with `Py_INCREF()`/`Py_DECREF()` in `tp_traverse` handlers

I think for the general issue I would like to: * Raise or warn if any of the public GC APIs are used while we are calling the traverse functions....

GC in free-threaded build has problems with `Py_INCREF()`/`Py_DECREF()` in `tp_traverse` handlers

> I'm also hesitant to rush any fixes I share the same concerns so don't worry. In any case all of these proposal would be only on debug builds and...