Pablo Galindo Salgado comments

Results 329 comments of


                                            Pablo Galindo Salgado

gh-117174: Add a new route in linecache to fetch interactive source code

I am not comfortable conflating the bugfix with a new feature. This has the danger to rush the new feature and as the issue is about a bug, it doesn't...

gh-117174: Add a new route in linecache to fetch interactive source code

Ok, I am convinced then. Thanks for the clarification and apologies for the back and forth. Let's make the changes you propose here in a private way and then we...

gh-117174: Add a new route in linecache to fetch interactive source code

I will fix this PR tomorrow to implement the code object backed check via a private API then then we could eliminate if we want when we made the feature...

gh-117174: Add a new route in linecache to fetch interactive source code

@gaogaotiantian I have changed the PR to implement a version of what you proposed, but there is an important problem. As we would be doing check by code object, it...

gh-117174: Add a new route in linecache to fetch interactive source code

Ah, good idea! I am going to tweak it a bit to not depend on `types` to preserve the optimizations done in 689ada79150f28b0053fa6c1fb646b75ab2cc200 but that can work indeed!

gh-117174: Add a new route in linecache to fetch interactive source code

This is quite tricky unfortunately. Passing down the frame to the `FrameSummary` extends the lifetime of the frame and that makes several tests in `test_asyncio` fail because coroutines are kept...

gh-117174: Add a new route in linecache to fetch interactive source code

Also some tests in test_gdb were failing because we are setting breakpoints in `builtin_id` and this is being triggered before the code that's passed as a template if we use...

gh-117174: Add a new route in linecache to fetch interactive source code

Also yet another problem: this doesn't work easily with the `warnings` module because the API it's based on getting a "message" (defined here https://github.com/python/cpython/blob/194fd17bc6cb73138e2fe8eb5ca34b19a6c3b25a/Lib/warnings.py#L420) and that doesn't easily get the...

riscv64 fails to build Python/perf_jit_trampoline.c: Unsupported target architecture

Hummm, looks like we are missing the definitions for the registers for riscv64 here: https://github.com/python/cpython/blob/af8c3d7a26d605099f5b3406a8d33ecddb77e8fb/Python/perf_jit_trampoline.c#L352-L376 @furkanonder can you take a look? Otherwise we may need to deactivate RISKV64 support meanwhile...

riscv64 fails to build Python/perf_jit_trampoline.c: Unsupported target architecture

I think it may be enough to add riskv here: https://github.com/python/cpython/blob/af8c3d7a26d605099f5b3406a8d33ecddb77e8fb/Python/perf_jit_trampoline.c#L371 but I am not sure about the numbers. It seems that they match the aarch64 but I would need...