Pablo Galindo Salgado

Results 329 comments of Pablo Galindo Salgado

I'm adding a new marker in #52 for checking memory leaks. Please @tonybaloney check if this would work for your use case.

Yup, this looks good to me. Thanks for working on this!

Check out https://github.com/sympy/sympy/pull/25224 for the factorial part

For the other part, please answer https://github.com/python/cpython/issues/105549#issuecomment-1584299719 and check out https://github.com/python/cpython/issues/105549#issuecomment-1584355294

With the fixes I mentioned and the tip of 3.12 this kind of error is the only one failing: ``` =============================================================================================== short test summary info ================================================================================================ FAILED sympy/parsing/tests/test_sympy_parser.py::test_parsing_definitions - tokenize.TokenError:...

Ok, I think I have a potential fix for all of them: ``` ❯ python -m pytest sympy/parsing/tests/ /Users/pgalindo3/github/python/3.12/venv/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:281: DeprecationWarning: 'importlib.abc.TraversableResources' is deprecated and slated for removal in Python 3.14...

> Thanks @pablogsal > > Longer term I think that this demonstrates that sympy should use a dedicated parser rather than leveraging something that is designed to parse Python code....

Actually, fixing the use case of `0x` is going to be much much harder because we need to branch in many places that we are not ready to. For instance,...

> How difficult is it only to support `1x, 2x, ..., 10x` than `0x`. Very easy, this we can do with very little maintainance burden. But any of the following...

Can you try `sympy` with https://github.com/python/cpython/pull/105555 and https://github.com/sympy/sympy/pull/25224 ?