Pablo

Results 97 comments of Pablo

PulsarIOTest.testReadFromSimpleTopic is very flaky

@MarcoRob are you working on this?

PulsarIOTest.testReadFromSimpleTopic is very flaky

hm from #17473 it seems more complex, huh? we'll see what I can do...

PulsarIOTest.testReadFromSimpleTopic is very flaky

gotcha. thanks @MarcoRob !

Agent should receive environment configuration from the supervisor

made both changes @evan-bradley : ) thanks! PTAL

enhancement(source metrics): Adding a histogram for event byte size

yeah good question - I believe users would create an `internal_metrics` source, and among these internal metrics we'd have this particular histogram. (newbie assumption): They can probably define histogram buckets...

enhancement(source metrics): Adding a histogram for event byte size

I'll fix up failed CI this evening (EST tzone)

enhancement(source metrics): Adding a histogram for event byte size

@jszwedko thanks for the review! Hopefully changes are enough!

enhancement(source metrics): Adding a histogram for event byte size

I've actually changed these because I was intending to cover the lower-level protocols (UDP, TCP-based ones), and was actually covering higher-level ones (HTTP-based ones) - please take another look? @jszwedko

enhancement(source metrics): Adding a histogram for event byte size

fwiw the fact that the possible regression appears in two different tests in two different runs (and those two tests are not correlated between runs) makes me think the regressions...

Verify counter behavior when mutated outside of a pipeline

Hi Neville! I work on Beam metrics. Currently, `counter.inc()` is a no-op if called outside any metrics context. This can be fixed in Beam - I'll file a bug in...