p0nce
p0nce
It's not my package, and I think DUB should reject invalid version specifications.
Is a (bad) solution for #2567
Note that all comments still need a different `_key`
Note that my PR seems incomplete, if multiple "_comment" are found the parser still complains: > Warning Error was: dub.internal.dyaml.composer.ComposerException@source\dub\internal\dyaml\composer.d(370): Key '_comment' appears multiple times in mapping (first: file C:\Users\guill\Desktop\Dplug\examples\distort\dub.json,line...
Why is JSON parsed with a YAML parser? YAML doesn't allow duplicated keys, but JSON does.
Oh I see, the right fix is perhaps a parsing option in upstream "configy"
> both of those are still way too slow, taking up possibly several hundred milliseconds - so it's not feasible to expect users to use them in all cases right...
I would also want a "comment" key to be accepted. :) this can be nice semantic information for displaying dub.json also eventually
Personally I can live with `_comment`, it's also a solution **if** someone really wants to extend dub.json format for their build (a bad idea, I learned)
Many reasons: - the developer experience has regressed. You used to be able to put comment in dub.json, now it's a massive error message - developers come to Dplug without...