Frames White

Julia benchmark includes compilation time & memory?

2

I wasn't sure if you were aware of this, but the julia benchmarks look like they are including the compilation time and associated memory use. (I am not sure, maybe...

Should `readdir` return a path?

7

It is kind of annoying that I can't do `readdir.(readdir(somepath))` to exact the 2 level hierachy. One solution to this would be for `readdir` to always return a path type....

add splitpath as filesystem function to docs

1

Added in Julia 1.1

Idea: RelativePath as own type, independent from other details

8

Conceptually, under this proposal we seperate the details of a protocal specific path as part of a abolute path (e.g. `PosixPath`, `S3Path`, `FTPPath` etc), from the simpiler relative path which...

Docs are not deploying

1

There doesn't seem to be a github pages branch being created so something is going wrong

Why is this allocating at all?

7

There is no real reason this code should allocate AFIACT. I think something is going wrong with Cassette.

Right now the code will not detect if you do allocations differently to the record so long as they are the same type. I have commented out code that does...

Use zygote2differential to wrap chainrules inputs

6

@mzgubic implemented zygote2differential as a better version of wrap_chainrules_inputs and added it to use in the code for `rrule_via_ad`. But it was not added to the normal path for when...

ismutable wrong for FillArrays

6

FillArrays are not mutable. ```julia julia> ArrayInterface.ismutable(typeof(Fill(4, (2,2)))) true ``` I think that https://github.com/SciML/ArrayInterface.jl/blob/730592e19c5e3effb086a5cc0b61ecc1a1936a76/src/ArrayInterface.jl#L75-L81 Should be ```julia function ismutable(::Type{T}) where {T

rename `has_sparsestruct` to `hassparsestruct`

2

I was reminded by https://github.com/invenia/BlueStyle/issues/36 If this *is* to go into `Base` then the base convention is not to put `_` after `has` see: `hasfield haskey hasmethod hasproperty`