ArrayInterface.jl icon indicating copy to clipboard operation
ArrayInterface.jl copied to clipboard

rename `has_sparsestruct` to `hassparsestruct`

Open oxinabox opened this issue 6 years ago • 2 comments

I was reminded by https://github.com/invenia/BlueStyle/issues/36

If this is to go into Base then the base convention is not to put _ after has see: hasfield haskey hasmethod hasproperty

oxinabox avatar Oct 06 '19 17:10 oxinabox

Sure. It'll need a major release though.

ChrisRackauckas avatar Oct 08 '19 04:10 ChrisRackauckas

It starts to read badly IMO, due to the combination of no separator and abbreviated words. Could we at least do something like hassparse_structure?

On Tue, Oct 8, 2019, 06:28 Christopher Rackauckas [email protected] wrote:

Sure. It'll need a major release though.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JuliaDiffEq/ArrayInterface.jl/issues/25?email_source=notifications&email_token=AB2FDMQHR6E7QHZ2PAJCIXLQNQEADA5CNFSM4I544CK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEASUWLY#issuecomment-539314991, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2FDMUUIPGL7JHJOZ3PPGDQNQEADANCNFSM4I544CKQ .

matbesancon avatar Oct 08 '19 04:10 matbesancon