ownAdx

Results 9 comments of ownAdx

> Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR: > > * [`modules/incrxBidAdapter.js`](https://github.com/prebid/Prebid.js/blob/72d423db7143ecc50b191ff3c1da0b2ae859eae6/modules/incrxBidAdapter.js#L78-L87) has 11 duplicated lines with [`modules/ownadxBidAdapter.js`](https://github.com/prebid/Prebid.js/blob/72d423db7143ecc50b191ff3c1da0b2ae859eae6/modules/ownadxBidAdapter.js#L84-L93) > > Reducing code duplication by importing...

> Why whould you need to update renderer.js files ? This doesn't seem to be what is needed to add a new adapter. As well as adding gulp-cli as a...

> > reordering lines in a json object appears to be a malicious commit > > Regarding patmmccann's comment, did you squash your commits to "hide" the malicious commit ?...

> update renderer.js > > > > reordering lines in a json object appears to be a malicious commit > > > > > > > > > Regarding patmmccann's...

> > By mistakely at initialy we was added some files which autoupdated like renderer.js to avoid we are reset branch with origin master and added our files owadxBidAdapter.js and...

> @ownAdx-prebid we'd prefer the robot was complaining so we can identify common patterns rather than reordering things to silence it. Minor duplication doesn't prevent merging. You can trust that...

> @ownAdx-prebid team, the server team is having some trouble contacting you [prebid/prebid-server#3774](https://github.com/prebid/prebid-server/issues/3774) [prebid/prebid-server-java#2868 (comment)](https://github.com/prebid/prebid-server-java/pull/2868#discussion_r1447109093) @patmmccann I have assigned OwnAdX prebid server team,will update on this issue.

> > @ownAdx-prebid team, the server team is having some trouble contacting you [prebid/prebid-server#3774](https://github.com/prebid/prebid-server/issues/3774) [prebid/prebid-server-java#2868 (comment)](https://github.com/prebid/prebid-server-java/pull/2868#discussion_r1447109093) > > @patmmccann I have assigned OwnAdX prebid server team,will update on this issue....

> > > > @ownAdx-prebid team, the server team is having some trouble contacting you [prebid/prebid-server#3774](https://github.com/prebid/prebid-server/issues/3774) [prebid/prebid-server-java#2868 (comment)](https://github.com/prebid/prebid-server-java/pull/2868#discussion_r1447109093) > > > > > > > > > @patmmccann I have...