OwnAdX Bid Adapter : initial release

[ownAdx-prebid]

Add new adapter

[github-actions[bot]]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/incrxBidAdapter.js has 11 duplicated lines with modules/ownadxBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

[ownAdx-prebid]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/incrxBidAdapter.js has 11 duplicated lines with modules/ownadxBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Remove duplicate lines

[JulieLorin]

reordering lines in a json object appears to be a malicious commit

Regarding patmmccann's comment, did you squash your commits to "hide" the malicious commit ?

[ownAdx-prebid]

Why whould you need to update renderer.js files ? This doesn't seem to be what is needed to add a new adapter. As well as adding gulp-cli as a production dependency

Also, to add a new bid adapter, you must create a pull request in prebid docs linking your adapter, and link it in this PR

@JulieLorin As per your recommendation, we have done the changes from our end. Below is pull request URL in prebid docs for OwnAdX: https://github.com/prebid/prebid.github.io/pull/5472

[ownAdx-prebid]

reordering lines in a json object appears to be a malicious commit

Regarding patmmccann's comment, did you squash your commits to "hide" the malicious commit ?

We have made the changes as per your recommendations in last commit

[JulieLorin]

reordering lines in a json object appears to be a malicious commit

Regarding patmmccann's comment, did you squash your commits to "hide" the malicious commit ?

We have made the changes as per your recommendations in last commit

There were 3 commits before your push, and there is now only one commit. From what I see, there are still the modifications you made (reordering lines in the object) to trick the code duplication robot. If I am mistaken, can you explain what you changed to resolve patmmccann's comment ?

[ownAdx-prebid]

update renderer.js

reordering lines in a json object appears to be a malicious commit

Regarding patmmccann's comment, did you squash your commits to "hide" the malicious commit ?

We have made the changes as per your recommendations in last commit

There were 3 commits before your push, and there is now only one commit. From what I see, there are still the modifications you made (reordering lines in the object) to trick the code duplication robot. If I am mistaken, can you explain what you changed to resolve patmmccann's comment ?

By mistakely at initialy we was added some files which autoupdated like renderer.js to avoid we are reset branch with origin master and added our files owadxBidAdapter.js and owadxBidAdapter_spec.js

we are already make changes for the below sugestions in this commit. 1.Duplicated lines 2.malicious attempt to silence the code duplication robot 3.reordering lines in a json object appears to be a malicious commit 4.Removing renderer.js file changes

[JulieLorin]

By mistakely at initialy we was added some files which autoupdated like renderer.js to avoid we are reset branch with origin master and added our files owadxBidAdapter.js and owadxBidAdapter_spec.js

we are already make changes for the below sugestions in this commit. 1.Duplicated lines 2.malicious attempt to silence the code duplication robot 3.reordering lines in a json object appears to be a malicious commit 4.Removing renderer.js file changes

I agree changes are fixed for files like renderer.js or added dependancies. But I don't understand for the rest, what did you change after the comment about the malicious commit ? From what I see, the malicious commit has only been squashed, and not reverted

[ownAdx-prebid]

By mistakely at initialy we was added some files which autoupdated like renderer.js to avoid we are reset branch with origin master and added our files owadxBidAdapter.js and owadxBidAdapter_spec.js we are already make changes for the below sugestions in this commit. 1.Duplicated lines 2.malicious attempt to silence the code duplication robot 3.reordering lines in a json object appears to be a malicious commit 4.Removing renderer.js file changes

I agree changes are fixed for files like renderer.js or added dependancies. But I don't understand for the rest, what did you change after the comment about the malicious commit ? From what I see, the malicious commit has only been squashed, and not reverted

We have only remove the changes in renderer.js file & gulp-cli

[patmmccann]

@ownAdx-prebid we'd prefer the robot was complaining so we can identify common patterns rather than reordering things to silence it. Minor duplication doesn't prevent merging. You can trust that @JulieLorin will not be unreasonable in her discretion.

[ownAdx-prebid]

@ownAdx-prebid we'd prefer the robot was complaining so we can identify common patterns rather than reordering things to silence it. Minor duplication doesn't prevent merging. You can trust that @JulieLorin will not be unreasonable in her discretion.

Can you please suggest what changes required

[patmmccann]

@ownAdx-prebid team, the server team is having some trouble contacting you https://github.com/prebid/prebid-server/issues/3774 https://github.com/prebid/prebid-server-java/pull/2868#discussion_r1447109093

[ownAdx-prebid]

@ownAdx-prebid team, the server team is having some trouble contacting you prebid/prebid-server#3774 prebid/prebid-server-java#2868 (comment)

@patmmccann I have assigned OwnAdX prebid server team,will update on this issue.

[ownAdx-prebid]

@ownAdx-prebid team, the server team is having some trouble contacting you prebid/prebid-server#3774 prebid/prebid-server-java#2868 (comment)

@patmmccann I have assigned OwnAdX prebid server team,will update on this issue.

@patmmccann Done from our end. Anything is required from our end for submitting the OwnAdX PrebidJS Adapter?

[JulieLorin]

@ownAdx-prebid team, the server team is having some trouble contacting you prebid/prebid-server#3774 prebid/prebid-server-java#2868 (comment)

@patmmccann I have assigned OwnAdX prebid server team,will update on this issue.

@patmmccann Done from our end. Anything is required from our end for submitting the OwnAdX PrebidJS Adapter?

Is it possible to have an answer on this question ? Thanks

[ownAdx-prebid]

@ownAdx-prebid team, the server team is having some trouble contacting you prebid/prebid-server#3774 prebid/prebid-server-java#2868 (comment)

@patmmccann I have assigned OwnAdX prebid server team,will update on this issue.

@patmmccann Done from our end. Anything is required from our end for submitting the OwnAdX PrebidJS Adapter?

Is it possible to have an answer on this question ? Thanks

@JulieLorin For 'token' is use for identify the tag for our end & 'aType' this field is use for identification flag for another Ad type in future use.If this field is hampering for any where in Adapter so we can remove it.

[JulieLorin]

@JulieLorin For 'token' is use for identify the tag for our end & 'aType' this field is use for identification flag for another Ad type in future use.If this field is hampering for any where in Adapter so we can remove it.

Thank you for providing an explanation. I think it is OK to keep them