Claudio Wunder

Results 1165 comments of Claudio Wunder

Hmm, it's not allowing me. Could you re-push the changes? I see that the commit is not verified and we kinda require signed commits.

Correct, let me update that.

> Ok next solution did not work also. I will not do anything after now XD Now it worked!

I appreciate the PR, but we're on a code-freeze right now, not to mention all the current "javascript/jquery" code is going to be trashed, as we transition to the codebase...

I wanted to mention that UA's are being sunset (frozen) (through phasing). It will be tough to predict future OS's User-Agents in the future, as browsers will stop updating them....

I'm not sure how adopted this API is. What is the caniuse.com of this API? Anyways, I would highly recommend not making PRs to nodejs.org, as this will all go...

Does that PR contain similar changes? (Leveraging the new API?)

@styfle could you rebase your PR so we can get this merged?

> Ok, I think I finally got the signing key thing figured out :) Yeah, you still have the first commit marked as unsigned. But that's fine, we can make...