oskarth

Results 252 comments of oskarth
trafficstars

With recent improvements https://github.com/oskarth/mopro/pull/76 and https://github.com/oskarth/mopro/pull/82 CI is much faster. Currently it takes 17m total (test-ios) / 20m (test-android) total, which is much better! https://github.com/oskarth/mopro/actions/runs/8058892793/job/22012399580 Probably some more things can...

One thing we could do is to be less aggressive in asserts here https://github.com/oskarth/mopro/blob/main/mopro-core/build.rs#L95-L105 And instead bubble up to run time, or compile time of user application. So if you...

We also want cleaner solution to this: https://github.com/oskarth/mopro/blob/main/.github/workflows/build-and-test.yml#L31-L32

@vivianjeng is there something missing for this? I haven't played with Android setup much, but to me main things that aren't clear are (1) CI (2) Lib/distribution on Android

Ok, if you want we can close this issue as initial Android support exists now. Can then create more targeted issues for those specific problems. Up to you!

I think we can close this issue now, makes more sense to have specific issues for improved Android support now I think

What's needed for this PR to be ready for review/merge? Can we gate this feature behind a feature flag maybe? So existing flow works but this can be toggled. Also...

@vivianjeng can this PR be closed with #75 merged?

Not high priority but would be nice to have.

This library also relevant for CUDA-enabled GPUs: https://github.com/ingonyama-zk/icicle