Or Shoval
Or Shoval
> > If go mod why -m still tells you that a module is not needed even when it's in your go list -m all, then it is this bug....
This will also create dependencies between vm based providers and kind providers (via gocli) eliminating benefits of provision manager, and the fact there will be dependency between the providers makes...
> @oshoval > > In general I think this code will still need to go through some reviews before a serious discussion is had about whether or no to actually...
> @oshoval I see your concerns, however I personally don't see them overlapping in terms of dependencies while yes, they both will be a part of the gocli, the only...
/sig code-quality
/cc @0xFelix
> This already goes into the right direction, but ideally I'd like to see pause and unpause being split into two separate pkgs. (`pkg/virtctl/pause` and `pkg/virtctl/unpause`) Can you do that...
the whole feature / main file is already named pause (and holds the sub package name) `pkg/virtctl/pause/pause.go` so i will introduce `pkg/virtctl/pause/pause_cmd/pause_cmd.go` and `pkg/virtctl/pause/unpause_cmd/unpause_cmd.go` is it ok ?
> I'd like to see it split into `pkg/virtctl/pause` and `pkg/virtctl/unpause`. but then where will be the main "shared" code that we have now on `pkg/virtctl/pause` ? it will stay...
rebased drafted, not ready yet