Or Shoval comments

Results 321 comments of


                                            Or Shoval

virtctl, pause: Refactor commands

Ready for review, thanks (lets see all pass, locally it did)

virtctl, pause: Refactor commands

marked the comments i addressed (rest can be done in a follow-up as we spoke) thanks

virtctl, pause: Refactor commands

@jcanocan can you take a look please ?

`should respect internalTrafficPolicy=Local Pod`

here https://github.com/ovn-kubernetes/ovn-kubernetes/actions/runs/14573164072/job/40875138418?pr=5145

cluster: Allow deploying controller on external cluster

addressed comments, ptal

cluster: Allow deploying controller on external cluster

tried to address comments, according the latest discussion, please take a look

cluster: Allow deploying controller on external cluster

yes, for example kubevirtci has CRIO

EIP test `disabling egress nodes impeding GRCP health check` is flaking a lot

seen here https://github.com/ovn-kubernetes/ovn-kubernetes/actions/runs/12852849945/job/35835711443?pr=4878 https://github.com/ovn-kubernetes/ovn-kubernetes/issues/4144 might be duplicate

EIP test `disabling egress nodes impeding GRCP health check` is flaking a lot

twice on same run https://github.com/ovn-kubernetes/ovn-kubernetes/actions/runs/13393113906/job/37407505211?pr=5000 https://github.com/ovn-kubernetes/ovn-kubernetes/actions/runs/13393113906/job/37407506933?pr=5000

EIP test `disabling egress nodes impeding GRCP health check` is flaking a lot

what about quarantine tests that flake a lot, or maybe them XFAIL (i.e run and report, but dont fail the lane if just they failed) it consumes lots of CI...