Or Shoval
Or Shoval
meant /lgtm
maybe this one suggests the solution https://github.com/kubevirt/cluster-network-addons-operator/issues/1804 ?
beside cosmetics there are no changes right ?
> /hold I want to manually check that no rbac was left out if any are left out, tests should find it, or we are missing tests, or those arent...
you didnt rebase correctly, please check it those seem to be missed, it will fail on OpenShift, but not on U/S (well it will also fail here as part of...
https://github.com/kubevirt/cluster-network-addons-operator/compare/968a49b0b0b0cee146b1409e44d9bebd457fd49e..cc6fe21598b5e551d09a187b03c9247b0dc4b3d3 you have here twice update
> Changed back to draft as WIP per offline discussion with @orelmisan. [Refactored](https://github.com/kubevirt/kubevirt/compare/06734ba859aa404dde7a79402993ff6ec1ff1dbe..439291a65f0ef131514d4748d79b236197393ef7) code and [rebased](https://github.com/kubevirt/kubevirt/compare/439291a65f0ef131514d4748d79b236197393ef7..cb154e73ad9f97c712f0904f29d1ba64fddab83e). Additional changes expected. /test all Can you please say what was done in high...
> [Changes](https://github.com/kubevirt/kubevirt/compare/a9c792fd7384e8e3f79c4f1a951e3dfe13ff056a..f2a46747ac07c0e55ca44d24cb81d7f007f899a4) include the must needed forgotten `kill()` sent to the `passt-repair` subrocess in case of timeout. In addition, stderr from `passt-repair` sub-process now wrapped in virt-handler logger. Before it...