Or Shoval comments

Results 321 comments of


                                            Or Shoval

Integrate NIC hotplug with LiveUpdate rollout strategy

Very nice Thanks /lgtm

Integrate NIC hotplug with LiveUpdate rollout strategy

/lgtm

FLAKE: External Gateway With Admin Policy Based External Route CRs e2e multiple external gateway validation Should validate ICMP connectivity to multiple external gateways for an ECMP scenario IPV4

https://github.com/ovn-org/ovn-kubernetes/actions/runs/10301096279/job/28513027290?pr=4590

Flake: [FAIL] External Gateway With Admin Policy Based External Route CRs e2e non-vxlan external gateway through a gateway pod Should validate ICMP connectivity to an external gateway's loopback address via a gateway pod [It] ipv4

also https://github.com/ovn-kubernetes/ovn-kubernetes/actions/runs/14573164072/jo/40875138468?pr=5145

multus: Install thick version

> Why does OVN-K require this ? > > Having more features is useless if OVN-K doesn't use any. For example it can allow us to use OVN k8s kind.sh...

multus: Install thick version

will close this, once we need hotplug we can return to this (multus dyn networks of course will be needed as well)

bridge, discover: Don't filter static routes in wider subnets

Nice thanks Please consider rewriting Release note, better be a free text, rather than commit title style

bridge, discover: Don't filter static routes in wider subnets

Don't filter static routes in wider subnets when bridge binding is used

bridge, discover: Don't filter static routes in wider subnets

nice /lgtm

net, vm ctrl: Adjust VM's detached iface clearing logic

Please consider to split the 4th commit to a follow-up already reviewed the first 3, and then the 4th was added, the PR already does enough with the first 3