Ömer Sinan Ağacan comments

Results 317 comments of


                                            Ömer Sinan Ağacan

Allow specifying conditions in external token patterns (contextual keywords)

@yannham I'm using an external lexer, "or" is just the name I give to the pattern. So in this example: (from my previous comment) ``` "or" => Token { kind:...

Potential bug in compiler: local variable read before written in generated code

> I’d just rip out all the reference buffer handling code. We don’t have these kinds of references anywhere on the IC Which code do you mean? I don't understand...

Different behavior for log() compared to print()

How do I run your code exactly? When I run it with `flutter run`, both in the browser and VM, the "Log ..." buttons don't do anything.

wasm integration tests are not running on firefox

It looks like the Firefox version we use in CI is buggy. I'm able to reproduce this with Firefox 115.15.0, but not with the latest stable (131.0). The behavior in...

Less than ideal type inference for type parameters in some cases

> Considering that this creates substantial breakage, is it really important to have the more specific type PbList? Could the more precise type be provided via a new API, such...

Flatten: Support `br_on_null`, `br_on_non_null`, `br_on_cast`, `br_on_cast_fail`

@tlively @kripken This is ready for reviews, but the testing here may not be sufficient. Because I use `ref_as_non_null` and `ref_cast` in the lowered code, when done incorectly these instructions...

`command` with pipe not working

Thanks for reporting. This issue came up before so I think we should document this somewhere. The `command` field does not accept arbitrary shell lines, it should be one command...