Ömer Sinan Ağacan

Results 317 comments of Ömer Sinan Ağacan

> the simpler option of using the wasm names section as a symbol map Do you mean simple for binaryen devs or end users? I think the simplicity here is...

Current version works as expected when I test it with https://dart-review.googlesource.com/c/sdk/+/386780, however there are a few TODOs I left in the code, which I'll try to fix next.

I believe this should be almost ready now, but I'm not sure how to test changes in `module-utils.cpp`. @kripken do we have any tests right now that checks source map...

Thanks @kripken. This should be ready for review now. I've added a separate test for inlining instead of modifying one of the existing tests, as there weren't any existing test...

@kripken I've addressed the comments but I'm not sure how to update the C API with an optional `uint32_t` parameter, see my question above.

To understand whether this is a bug in this package or in SDK, do you also get wrong stack traces if you use [`StackTrace.current`](https://api.dart.dev/stable/3.5.3/dart-core/StackTrace/current.html) instead of `Trace.current`?

That seems likely, however I get the same error with #637 which is supposed to fix #186.

Another use case for the `--jobs` parameter: I modified my interpreter to generate some debug information to a file, but with multiple jobs the interpreter processes modify the file at...

> I'd be interested in the sort of things you'd want to pass files manually to it would be for since I'd also like to improve the file detection &...