Ömer Sinan Ağacan

Results 317 comments of Ömer Sinan Ağacan

I debugged this. It's an issue with omitting bounds checks, which we do by default with `-O4`. Adding `-E --no-omit-bounds-checks` fixes the issue. The illegal cast happens here: Big stack...

SDK issue for discrepancies between dart2js and dart2wasm: https://github.com/dart-lang/sdk/issues/56949.

@eyebrowsoffire is this code path tested on the CI? On the CI `stringBuiltinSupported` will be `false`, locally can I run the tests that use this code with a custom Chrome...

I'm moving the compilation logic to the generated runtime blob in https://dart-review.googlesource.com/c/sdk/+/381581. I'll get back to this once that's merged and rolled into the engine.

CI is failing with unrelated macos issue. Should we merge this? @mkustermann @eyebrowsoffire

Even if `measureUserAgentSpecificMemory` is inaccurate, it's a browser API, not dart2wasm specific. So I'm not sure what can be done about this (assuming it's inaccurate) in dart2wasm. To have an...

I just realized that I'm fixing the same issue with #7669 and #7670. (note: #7670 is based on #7669, it includes changes in #7669) My fix is different: I don't...

I think the PRs linked above should be "safer" in the sense that they won't cause accidentally inlining too much, because they don't change size calculations. But even with those...

> I haven't looked at the source yet, but one nice solution is to add a server config called autoconnect: which defaults to true - preserving normal behavior. I also...

Thanks for reporting. I think this function needs an update to not increment the X coordinate on zero-width chars: https://github.com/osa1/tiny/blob/8747b6ba89c95dc6c1793404065d232341a6df08/crates/libtiny_tui/src/termbox.rs#L6-L22 I can try fixing this later this evening, but if...