Senthil Kumaran comments

Results 112 comments of


                                            Senthil Kumaran

Week 34: AWS Lambda

Good write-up. I liked your clear explanation of AWS lambda usefulness. The thing to note is, the traditional way of having the API end-point with the web service running on...

Could not resolve Note Model when trying to generate Cloze

Thank you, @fonol I will try that!

[WIP] refactor networkutils.NetworkAPI & remove legacy features

/not stale

Validate Security Groups before attempt to attach to ENI Config

@jayanthvn - yes, will do that. I will also refactor a bit, and see where to add tests for this. thank you.

Validate Security Groups before attempt to attach to ENI Config

Hi @jayanthvn - this is ready for review.

Validate Security Groups before attempt to attach to ENI Config

Hi @achevuru ; I have addressed the review comments. Please take a look.

Validate Security Groups before attempt to attach to ENI Config

> I'm thinking we can instead do that whenever we derive the ENIConfig CRD for that node. Good idea. I will change it.

Validate Security Groups before attempt to attach to ENI Config

I will verify the call graph, @jayanthvn . I placed this based on the assumption to call `before` AllocENI; but wasn't sure if we can optimize it further, until I...

Validate Security Groups before attempt to attach to ENI Config

Hi @achevuru , and @jayanthvn I spent sometime looking at where to best introduce this again. Calling the validation logic in `(c *IPAMContext) nodeInit()` pkg/ipamd/ipamd.go seems like the place to...

Validate Security Groups before attempt to attach to ENI Config

Recent push was only a rebase master. Hi @jayanthvn , @achevuru - This is ready for review. Thank you.