orende

Results 12 comments of orende

Still, it would be nice with a reflection-based solution for mapping results to records...

Any updates on this issue?

@Creteil Did you manage to build a .deb? If yes, can you share?

@sharkwouter I opened up a PR (#581) implementing this, in case you missed it.

This has been done as part of #573 except for this [line](https://github.com/sharkwouter/minigalaxy/blob/master/minigalaxy/launcher.py#L256) which I can't quite figure out if it's intentionally using a print statement or not.

My bad, I was using minigalaxy on KDE (Kubuntu) and didn't even realize it was a Gnome app. Having notifications would be a nice feature though.

I've made a PR with a proposal for implementing notifications when game downloads and installs finish, Have a look and let me know if this is what you were looking...

Thanks for the review! I suspect there could be a race condition where the GTK work is sometimes done on the main thread (and working as expected) and sometimes done...

After moving the GUI-related function calls in `library.initialize()` to GLib.idle_add, I started having trouble with credentials not being shared across threads. Still investigating that, but haven't had much time to...

Can confirm, this is happening to me as well with trimage 1.0.6 and Python 3.8.5 on Ubuntu 20.04.1 LTS.