Joshua Oreman

Results 96 comments of Joshua Oreman

@1ncande5cence I am not seeing an FD leak: ``` >>> import os, netfilterqueue >>> os.listdir("/proc/self/fd") ['0', '1', '2', '3'] >>> nfq = netfilterqueue.NetfilterQueue() >>> os.listdir("/proc/self/fd") ['0', '1', '2', '3', '4']...

@DOWRIGHTTV it's to support pushing `run()` into a background thread (presumably using a queue of some sort to pass the packets to the main thread for processing), such as you...

I like the name "nursery". If we choose a new one, I'd hope that it share some of the properties of "nursery" that make me like it: - not in...

@maffoo - giving the nursery object a name makes it possible to give another task the ability to start tasks in your scope, even though it is not in that...

I thought of yet another possibility recently: Say that if you want to pass Trio options, you need to pass the function to call through a kwarg too (`target=`?), and...

Ooh, I like using dunders a lot better than just leading underscores. Friendly amendment: can we use `_sunder_` names rather than `__dunder__` names? There's precedent (`enum` in the standard library),...

> This feature is blocking the project I'm working on. Given that it's a ten line feature change, relatively simple, and that the review was primarily about semantics I think...

I like the proposed `GracefulShutdownManager` in terms of its simplicity-to-functionality ratio, but I don't think it necessarily solves all the problems that lead people to want something like graceful cancellation....

I've written an implementation of the "cancel scopes have grace periods" idea, on the `graceperiod` branch of oremanj/trio. It's on top of my unbound cancel scope diff (#835) so no...

Ooh, I really like this framework for thinking about structured cancellation. It nicely decouples the "shut down my server in an orderly way" and "give me a bit more time...