Joshua Oreman

Results 120 comments of Joshua Oreman

It would be possible to handle this backwards-compatibly by encouraging hookwrappers to say `value = (yield).get_result()`. pluggy would still construct a _Result object for backcompat reasons, but it would immediately...

If you have two mechanisms, you don't need my suggestion. If you want to stick with only one mechanism, my suggestion is a way to make it more pleasant to...

FWIW, I'd support dropping `iterable_is_async` entirely, and having the semantics be "async iterable if it has an `__aiter__`, sync iterable if not". If someone wants an iterable-both-ways to be treated...

Hmm. * Discard vs send-on-channel can be the same function by taking an optional channel argument (as run_on_each already does). * run_on_each could also take optional task_status; if used with...

I think Trio's nondeterministic scheduling will foil most order-preservation assumptions pretty quickly, so I'm not worried about issues with the default being ordered. I think `ordered=True` would be useful to...

I originally made this maximally paranoid about the minor behavioral differences, but on reflection I'm not sure that level of paranoia is necessary -- I think it would reasonable to...

Put `@asynccontextmanager` on the class's `__call__` method, not on the class itself. That will produce a class whose instances yield async generators when they are called. If that doesn't meet...

I just looked at the linked issue. If you are given the class definition and can't modify it, you could do something like `cm = asynccontextmanager(MyClass.__call__); async with cm(MyClass()) as...

@njsmith ping? I'm interested in getting this merged and a new async_generator version released with it and #15 so I can depend on that version in other projects (e.g. make...

Thanks for the review! I would say the pitch of #16 is "you can use `await yield_from_` in a native async generator with native `yield` statements", like the async_generator package...