Orel Ben Neriah

Results 14 comments of Orel Ben Neriah

> I think your example `10.42ft / 2m` results in number, which is already supported by `ceil`, so I think that doesn't make a difference. > > The core here...

@josdejong I believe this issue can be closed now.

Yes, I deployed to dev with a custom domain first. At this point, this is resolved on my end, but it might be helpful to refer to this issue if...

> OK, I took a quick look at the generated documentation, enough to know that before this could be merged, someone needs to go over it with a fine-tooth comb....

> I don't know that the docgenerator or the doc tests have the ability to handle multiple functions in a source file. I don't think there are any working examples...

> reviewing Sounds good. I will get started on that soon.

Is there a restriction that the matrix or array must contain only units? I believe that to be the case. If so, I would like to update the types further....

> Thanks for the updates. I made two more comments, can you have a look at those? > > > Is there a restriction that the matrix or array must...

> > Is the desired behaviour that matrices and arrays only contain units when the second or third argument to the `ceil, floor, fix, or round` function is a unit?...

> Thanks for the updates! > > The improved TypeScript support is awesome, and with the generic `MathCollection` we can refine a lot more of the type definitions. However we're...