Orel Ben Neriah

Results 14 comments of Orel Ben Neriah

I did find a small error in one of the multiply function types. Would you like me to file an issue or fix it in one of the upcoming PRs?...

> ad a thorough look at the changes in the type definitions. I expect the changes are not be breaking in normal, practical cases, but there may be tricky edge...

@josdejong @ericman314 It's been a while since this issue was opened. Are there any updates on this? Also, if we are waiting on UnitMath, can we have a simpler implementation...

I believe it has to do with this function. https://github.com/facebook/lexical/blob/409c65e56e447452da6fa7022672aeb3392518ca/packages/lexical/src/LexicalSelection.ts#L1334-L1341 I tried to figure it out myself, but the function's assumptions in the third case are unclear to me.