Oliver Beckstein

Results 898 comments of Oliver Beckstein

I am using pre-commit with black 24 and it passes and then our linters/black fails; I probably need to sync the settings in some way, until then there'll be more...

Thanks @IAlibay , just updated CHANGELOG with output precision changes and ran black locally again. I think I just don't have the right settings for pre-commit black and our black...

(This got automerged on approval... I had _thought_ it would wait for _all_ of CI... oops, sorry. All linters and Linux had passed at least. If anything gets messed up...

@raulloiscuns your PR got merged and your fix will be in 2.10.0. 🎉 Thank you very much for identifying the problem and proposing a solution!

I am using the following `.pre-commit.yml` ```yaml # Pre-commit configuration for MDAnalysis repos: # Black - Python code formatter - repo: https://github.com/psf/black # workaround https://github.com/psf/black/issues/2493#issuecomment-1081987650 rev: 'refs/tags/24.10.0:refs/tags/24.10.0' hooks: - id:...

@tanishy7777 are you still interested in continuing the PR? Did I read your preliminary benchmark correctly in that your changes improve execution from ~12.5s to ~11s ? That's not an...

@p-j-smith would you be able to look after this PR, if @tanishy7777 were to continue working on it?

@p-j-smith If you don't have time, please un-assign yourself. If you take on PR-shepherding, feel free to close the PR once you consider it stale.

@tanishy7777 thanks for all your contributions. As you know, reviewer time is pretty precious. I asked @marinegor to look at PR #4896 already so please be understanding if this one...

@tanishy7777 just as a heads-up: Egor told us he has very little availability, so we'll have to find other reviewers to continue here. As the first step where you can...