Oliver Beckstein

Results 898 comments of Oliver Beckstein

In principle, tests should pass everywhere. The Azure tests time out in the test ``` _________________________ Test_Fetch_Pdb.test_timeout _________________________ ``` which looks like something that you added. I haven't looked at...

@jauy123 do you have time to pick up this PR again? Would be great to have the feature in 2.10!

Even without code review, you can try to make the linters happy (click and see what they're complaining about – probably start by running `black` on the files that you...

@jauy123 add pooch to https://github.com/MDAnalysis/mdanalysis/blob/develop/.github/actions/setup-deps/action.yaml so that it is installed as part of the GH actions workflow.

For windows Azure, make sure that your tests are skipped if pooch is not installed (there's a skipif decorator IIRC).

@jauy123 can you please "Resolve conflicts" and get the PR into a mergeable state? You have to move all your CHANGELOG info to the new 2.11 entry - move your...

@jauy123 I think @BradyAJohnston is currently [here](https://dbg.org/), maybe catch him ;-). Lesson for the future: if you have the opportunity to corner a reviewer of one of your PRs, have...

Regarding `pathlib`: Using `Path` objects is forward looking and anything that `os.path` can do, you can do with a `Path`, but in a more abstract (and thus more robust) manner....

I didn't know that `os.path` was so flexible. I learned something new.

@gitzhangch thanks for looking into the code. Suggestions for performance improvements are always very welcome! Could you create a PR with your changes? Then we can see if the tests...