python-flask

python-flask copied to clipboard

I mean is not None?

1

https://github.com/opentracing-contrib/python-flask/blob/c7270ca4c6ac9c5189c45c60714afd582af50087/tests/test_flask_tracing.py#L225

ivnminin

Question: How use opentracing.global_tracer() when using jaeger_client lib

3

This example https://github.com/opentracing-contrib/python-flask/blob/master/example/server.py#L28 uses the tracer returned by jaeger_client's `initialize_tracer` method. This method internally sets the `opentracing.tracer` to jaeger tracer object, this means for any request handler there after can...

jan25

fix trace wrapper

1

Added **functools.wraps** for save meta-info of decorated function.

MyGodIsHe

`start_span` on `FlaskTracer` should delegate to the underlying tracer implementation

4

I'm trying to manually add a span to a trace using the jaeger Python client, as [described in the documentation](https://github.com/opentracing-contrib/python-flask/tree/master/example#add-spans-to-the-trace-manually). However in the example, the span is created by calling...

jscn

Adopt FlaskScopeManager

1

These changes introduce an optional scope manager using Flask's stack, as originally proposed in https://github.com/opentracing/opentracing-python/pull/105. This is helpful for ensuring that the active span obtained anywhere in a view function's...

rmfitzpatrick

Does this support OT 2.0 and scope managers?

6

cc @carlosalberto

yurishkuro

Allow to have the app set late for FlaskTracing.

8

Addresses #22

carlosalberto

Add examples with blueprints usage.

2

Most production flask apps would use blueprints. Add documentation to show how to achieve tracing of such application layout.

ror6ax

### How to reproduce the issue Let's use whatever tracer (I used jaeger for this example) and use the trace decorator. Ex.: ```python from flask import Flask from flask_opentracing import...

Fortiz2305

I think this change fixes #45 , sending the http response to the after request function so the tag will be added [here](https://github.com/Fortiz2305/python-flask/blob/master/flask_opentracing/tracing.py#L152)

Fortiz2305