python-flask icon indicating copy to clipboard operation
python-flask copied to clipboard

Published 20 hours ago • verified publisher icon opentracing-contrib

Does this support OT 2.0 and scope managers?

Open yurishkuro opened this issue 6 years ago • 6 comments

cc @carlosalberto

yurishkuro avatar Aug 20 '18 02:08 yurishkuro

It does not yet - I've been working on changes (+ additional cleanups) on v1.0.0 branches for Python instrumentation in contrib, and I'd expect to have them ready for Flask by the end of the week (already started it).

carlosalberto avatar Aug 20 '18 14:08 carlosalberto

looking forward to it

yurishkuro avatar Aug 28 '18 04:08 yurishkuro

@carlosalberto, does this require a FlaskScopeManager in https://github.com/opentracing/opentracing-python that uses _request_ctx_stack? I'd be happy to take a crack at that if so.

edit: Looking at the Tornado scope manager, it seemed like this was needed so I made an attempt: https://github.com/opentracing/opentracing-python/pull/105

I'll be sure to open a PR with my tracer changes that source this if adopted in opentracing-python.

rmfitzpatrick avatar Sep 10 '18 14:09 rmfitzpatrick

@carlosalberto does #23 resolve this one?

yurishkuro avatar Oct 15 '18 16:10 yurishkuro

ping @carlosalberto

Jamim avatar Dec 19 '18 15:12 Jamim

Can't seem to get this working with Flask-Opentracing 1.1.0.

analytically avatar May 12 '20 09:05 analytically