python-flask icon indicating copy to clipboard operation
python-flask copied to clipboard

Published 20 hours ago • verified publisher icon opentracing-contrib

I mean is not None?

Open ivnminin opened this issue 3 years ago • 1 comments

https://github.com/opentracing-contrib/python-flask/blob/c7270ca4c6ac9c5189c45c60714afd582af50087/tests/test_flask_tracing.py#L225

ivnminin avatar Apr 23 '21 16:04 ivnminin

Why are we checking code 200 in this test? There should be a 500 code. Doesn't work

            scope.span.set_tag(tags.ERROR, True)
            scope.span.log_kv({
                'event': tags.ERROR,
                'error.object': error,
            })

ivnminin avatar Apr 24 '21 15:04 ivnminin

This package is no longer being maintained, users should migrate to the opentelemetry-api package.

Closing.

ptmcg avatar Feb 29 '24 22:02 ptmcg