Yuto Yamada

Results 13 comments of Yuto Yamada

Hi, @geekygirlsarah I would like to contribute to Code Thesaurus Could you please assign this to me?

Hi, @dgrisonnet @logicalhan Could you please take a look at PR whenever you can? If additional work is necessary, please let me know. Thank you in advance.

Let me try to finish it by Wednesday as much as possible but it might be difficult...

I created PR (https://github.com/kubernetes/kube-state-metrics/pull/2145) to implement the feature. When `--metric-annotations-allowlist` and `--metric-labels-allowlist` are not configured, `kube_*_annotations` and `kube_*_labels` will not be provided by `kube-state-metrics`.

Since there is no update for a long time, I created PR (https://github.com/kubernetes/kube-state-metrics/pull/2146).

@ryanjbaxter Thank you for the review. May I know which approach you prefer regarding context implementation? **Approach A (Example)** ```java public class RequestContext { private static final ThreadLocal context =...

@ryanjbaxter I've implemented `RequestContext` to pass query parameters to downstream methods. When we introduce new query parameters that need to be passed to downstream methods like `forceRefresh` next time, we...

@spencergibb Should we add both query parameters and path parameters to `RequestContext` or just query parameters? In my opinion, adding just query parameters is better because adding path parameters requires...

@ryanjbaxter I agree with you What about to add just query parameters to `RequestContext` in this PR and work on other parameters in another PR? Or it's also reasonable to...

@ryanjbaxter @spencergibb I've created another PR to move the existing parameters to `RequestContext`. Could you please review https://github.com/spring-cloud/spring-cloud-config/pull/2408?