codethesaur.us icon indicating copy to clipboard operation
codethesaur.us copied to clipboard

Add Ruby strings

Open geekygirlsarah opened this issue 3 years ago • 4 comments

Description

Strings for Ruby aren't presently on Code Thesaurus. This issue is to add that concept to the system.

Directions

  • On the home page, on the right side (the reference sheet side), choose the language and version, and then the concept.
  • The page says the data doesn't exist, but clicking the arrow for the template will provide the template and file for you to use.
  • Save that file in /web/thesauruses/[language]/[version]/[concept].json.
  • Fill out all of the "code" sections.
  • Add in "not-implemented": "true" if the concept doesn't exist in the language. You can then delete the "code" line.
  • Add in "comment": if you wish to explain something in the code
  • Delete the "name": fields before your PR
  • Save, commit your code, push to your fork, then make a PR.
  • Watch the checks to make sure they all pass. If they don't, click on "Details" and it should tell you what to modify.

Claiming This Issue

Please leave a comment below so I can assign you to it. This is to prevent multiple people from working on the same issue.

Check out CONTRIBUTING.md for more information on how to contribute.

Check out https://docs.codethesaur.us/thesaurus/ for information on how Code Thesaurus works and how to add to the thesauruses.

Need Help?

Leave a comment on here with your question, or feel free to ask @geekygirlsarah on Twitter. You can also email [email protected] too.

Thanks!

We really value and appreciate the additions people make to Code Thesaurus, no matter how large or small. So thank you for taking the time to work on this!

geekygirlsarah avatar Oct 31 '21 04:10 geekygirlsarah

Hi, @geekygirlsarah I would like to contribute to Code Thesaurus Could you please assign this to me?

opeco17 avatar Nov 03 '21 12:11 opeco17

I'll give you this one too! Let me know if you have any questions!

geekygirlsarah avatar Nov 03 '21 13:11 geekygirlsarah

Hey @opeco17, how is this coming along? I haven't seen any updates and it's been over 3 weeks now. If you still want the issue, let me know otherwise I'll probably unassign you. And if you have any questions, let me know too!

geekygirlsarah avatar Nov 25 '21 02:11 geekygirlsarah

Haven't heard back so I'm removing them. (If you still want it, let me know and I'll add you back.)

geekygirlsarah avatar Nov 29 '21 19:11 geekygirlsarah

Hello, I would like to contribute to solving this issue. I am an enthusiastic Ruby developer and would like to try it very much. This project is very awesome and I like the website a lot. I have read the Documentation and especially I read carefully the "Contributing" section but if you have any other tips I am interested in having a look before trying it.

Best regards, André

pulgamecanica avatar Oct 03 '22 16:10 pulgamecanica

I also have a suggestion, in case you haven't considered it. Perhaps, the JSON should have another section to add the references. I love references, to confirm the information, or if someone wants to dig deeper about a certain subject... Cheers :)

pulgamecanica avatar Oct 03 '22 16:10 pulgamecanica

Hey @pulgamecanica, I'll assign you then! And yeah, let me know if you have any questions.

And I suppose great minds think alike, there's #188 for the references.

geekygirlsarah avatar Oct 03 '22 17:10 geekygirlsarah

Thank's I'll give my best and I will try to be consistent :D

pulgamecanica avatar Oct 03 '22 17:10 pulgamecanica

Hello!

Today I will be working on the JSON, yesterday I was able to run the docker-compose without many issues, I worked with Django before and I was happy to see it again, so without further ado, I will do my best and I will use "The Well Grounded Rubyist" 📖 as a reference to get all the ideas straight and without much complications for any reader! :D ✏️

pulgamecanica avatar Oct 04 '22 11:10 pulgamecanica

Screen Shot 2022-10-04 at 13 08 23

I'm ready to goooo, eager to finish. Again, thanks a lot for letting me contribute, this is so cool!

pulgamecanica avatar Oct 04 '22 12:10 pulgamecanica

I'm glad you're so excited @pulgamecanica ! I hope you have some fun with it, maybe learn some new things along the way. Again, let me know if you have any questions!

geekygirlsarah avatar Oct 04 '22 14:10 geekygirlsarah

I have finished, I will perform now a PR :D

I also found one little tiny typo which I would love to fix :D not sure if I should create an issue for it though... The typo is here: https://codethesaur.us/reference/?concept=strings&lang=java%3B17 It's because they forgot to escape the backslash so it actually created a new line instead of showing the new line character.


IMG showing the exact typo:

Screen Shot 2022-10-04 at 18 15 14

pulgamecanica avatar Oct 04 '22 17:10 pulgamecanica

I also found one little tiny typo which I would love to fix :D not sure if I should create an issue for it though... The typo is here: https://codethesaur.us/reference/?concept=strings&lang=java%3B17 It's because they forgot to escape the backslash so it actually created a new line instead of showing the new line character.

Good catch! You can sneak it into #555 if you want or you can make a new PR. (no issue needed)

geekygirlsarah avatar Oct 04 '22 17:10 geekygirlsarah

Overall it was very nice to do it, but I couldn't find a proper answer for the second question, so I entered "no need?" because I really didn't know what to put.

Screen Shot 2022-10-04 at 18 29 22

So if you know what I could put there to make it understandable for the readers, I would appreciate it. The string is built.in class which comes along all the Modules for Ruby so it is included by default, I don't know how to explain this very well.

pulgamecanica avatar Oct 04 '22 17:10 pulgamecanica

I closed the PR because I didn't want the "No need?" to go there haha I forgot about it... only now I realized

pulgamecanica avatar Oct 04 '22 17:10 pulgamecanica

Oh you don't have to close and open a new one. Just push new changes. Github updates it automatically.

geekygirlsarah avatar Oct 04 '22 17:10 geekygirlsarah

I will sneak that fix for the Java lang on the PR 😄 Well then, I'll do that.

pulgamecanica avatar Oct 04 '22 17:10 pulgamecanica

Want me to reopen #555 then? You can edit the text of the PR too if something changes.

geekygirlsarah avatar Oct 04 '22 17:10 geekygirlsarah

I would appreciate that, thank you.

pulgamecanica avatar Oct 04 '22 17:10 pulgamecanica

Ohhh wow.... that's so nice, it really did it automatically.... now it shows the 4 files changed on the PR. That's so cool.

pulgamecanica avatar Oct 04 '22 17:10 pulgamecanica

Now it says: "Built-in included in the default Modules" instead of "No need? ✅

pulgamecanica avatar Oct 04 '22 17:10 pulgamecanica

Srry for not updating this, I'll see how I can finish this soon!

Wrong issue... I meant it for the Ruby operators... Cheers.

pulgamecanica avatar Nov 23 '22 10:11 pulgamecanica

That's alright! (You can always delete comments too)

geekygirlsarah avatar Nov 23 '22 17:11 geekygirlsarah

I don't like much to delete comments because you might recieve an email about someone saying something and then you can never find it hahaha

pulgamecanica avatar Nov 23 '22 18:11 pulgamecanica

Alright, that's fair too!

geekygirlsarah avatar Nov 23 '22 18:11 geekygirlsarah