Onsi Fakhouri

Results 517 comments of Onsi Fakhouri

hey thanks @Itxaka - there _was_ support for getting a report before the suite ran if you implemented a custom reporter in V1 but it was a bit janky (specifically,...

And thanks for an offer for a PR - I think this bit of code will be kind of gnarly, though... so not a great candidate as a PR for...

hey @kurt-google - I should definitely update the docs. Since Ginkgo can run multiple suites in one go the intent is for you to let Ginkgo manage where the files...

hey @psturc thanks for reporting this. Looks like it might be an edge-case bug that you've found. I'll dig into it and see how if I can push a fix...

Take a look here: https://onsi.github.io/ginkgo/#separating-diagnostics-collection-and-teardown-justaftereach (not so much the justaftereach - more the CurrentSpecReport() bit)

hey - probably the best way to do this is via something like: ``` var _ = BeforeSuite(func() { Expect(someComplexSetup()).To(Succeed()) }) var _ = ReportAfterSuite("cleanup in case of failure", func(report...

hey there @Thor-wl - seems like an issue in the script. Ginkgo's github repo includes an MIT license in the root directory. You may want to open an issue with...

@rlpowell I'm sorry to hear this turned into a multi-hour debug session for you. I'll look into why the `signal: killed` message is being swallowed, presumably by the Ginkgo CLI,...

hey @SamYuan1990 there are a few issues with profiling in v1 that are fixed in v2 (which will release in the next couple of months). For now you can use...