Onsi Fakhouri

Results 516 comments of Onsi Fakhouri

A couple of thoughts, perhaps to allay (corroborate?) some of these concerns from my point of view: On restricting to test code: While it's true that this pattern doesn't need...

Yet another time where I find myself wishing functions could have properties. Wouldn't it be so much (relatively) cleaner if we could write: ``` foo := Successfully(Bar(42)) fooo := Successfully.Two(Barr(42))...

I think config files will be the future for this sort of stuff in both ginkgo and gomega. But it's not a super high priority at the moment :/

hey there - are these happening consistently or are they flaky?

I'm running `gmeasure` locally with `ginkgo -p -until-it-fails` and I'm not managing to get any failures. as you can see these are timing based tests and while I've tried to...

+1 to reimplementing. This is dangerous territory... asserting equality can be tricky business in Go and relying on DeepEqual is a safe way to do so. Maintaining control over the...

My response wasn't very clear. I would love to have improved diff identification in Gomega. I'd want the code that does equality to be: - a part of Gomega so...

hey `go-cmp` looks pretty good. I can imagine a `Compare` or `BeComparableTo` matcher that can accept `go-cmp` options and simply runs go-cmp in the background. I don't have a lot...

yes, exactly like that. I could also imagine a configurable flag on Gomega that would cause `Equal` to behave like `go-cmp` and so folks could try switching over more incrementally.