Onkar Hanumante
Onkar Hanumante
@bruno-siira PR tests are failing. Should push change to fix ``` server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990) --- FAIL: TestNewExchange (0.01s) exchange_test.go:89: NewExchange produced an Exchange without bidder resetdigital E0207 18:20:15.140596 34687 exchange.go:817] OpenRTB...
@bruno-siira should create docs PR in https://github.com/prebid/prebid.github.io repo. This PR is needed for include `ResetDigital` on prebid server docs - https://prebid.org/product-suite/prebid-server/ Additionally, refer https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#prebid-server---new-bid-adapter-go for guidelines to add new adapter...
@bruno-siira ple > @bruno-siira > > PR tests are failing. Should push change to fix > > ``` > server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990) > --- FAIL: TestNewExchange (0.01s) > exchange_test.go:89: NewExchange produced...
> > > @bruno-siira ple > > > > @bruno-siira > > > > PR tests are failing. Should push change to fix > > > > ``` > >...
> > > > > @bruno-siira ple > > > > > > @bruno-siira > > > > > > PR tests are failing. Should push change to fix >...
> > @bruno-siira tests are failing because `ResetDigital` adapter is not registered. Test log clearly states ` [resetdigital: builder not registered]` > > Sorry, I misunderstood the problem. Where should...
@bruno-siira PR is failing due to following reasons ``` Running go vet check # github.com/prebid/prebid-server/v2/openrtb_ext Error: openrtb_ext/imp_resetdigital.go:4:2: struct field cid has json tag but is not exported Error: openrtb_ext/imp_resetdigital.go:5:2: struct...
@bruno-siira PR has few unaddressed comments. PTAL
- https://github.com/prebid/prebid-server/pull/3452/files#r1553471267 - https://github.com/prebid/prebid-server/pull/3452/files#r1553490761 - https://github.com/prebid/prebid-server/pull/3452/files#r1553659997 - https://github.com/prebid/prebid-server/pull/3452/files#r1553664849 - https://github.com/prebid/prebid-server/pull/3452/files#r1553666487 - https://github.com/prebid/prebid-server/pull/3452/files#r1553674609 - https://github.com/prebid/prebid-server/pull/3452/files#r1553684914 - https://github.com/prebid/prebid-server/pull/3452/files#r1553688982 - https://github.com/prebid/prebid-server/pull/3452/files#r1553696154 - https://github.com/prebid/prebid-server/pull/3452/files#r1553711184 - https://github.com/prebid/prebid-server/pull/3452/files#r1478680728 - https://github.com/prebid/prebid-server/pull/3452/files#r1482915519 - https://github.com/prebid/prebid-server/pull/3452/files#r1612700678 - https://github.com/prebid/prebid-server/pull/3452/files#r1553486214 @bruno-siira requesting...
@bruno-siira closing this PR. You can open PR after addressing the open comments