prebid-server New Adapter: ResetDigital

New adapter for ResetDigital on Go

Feb 05 '24 18:02 bruno-siira

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 70de1905b375ab0431ebb15e6085919fb051e788

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:56:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:68:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:85:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:93:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:101:	getCurrency		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:109:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:150:	processDataFromRequest	90.9%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:171:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:207:	getBidFromResponse	93.8%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:243:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:250:	getBidType		28.6%
total:										(statements)		73.6%

Feb 05 '24 18:02 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, dd48470b27b58c2b66b153b3a85b9c4d3429d3ea

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.8%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:258:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:265:	getBidType		28.6%
total:										(statements)		75.5%

Feb 07 '24 17:02 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 32551fce807983ff42acfdad8e05dc8c1807adb7

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.8%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:258:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:265:	getBidType		28.6%
total:										(statements)		75.5%

Feb 07 '24 17:02 github-actions[bot]

@bruno-siira

PR tests are failing. Should push change to fix

server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990)
--- FAIL: TestNewExchange (0.01s)
    exchange_test.go:89: NewExchange produced an Exchange without bidder resetdigital
E0207 18:20:15.140596   34687 exchange.go:817] OpenRTB auction recovered panic from Bidder appnexus: panic!. Account id: test1, All Bidders: bidder1,bidder2, Stack trace is: goroutine 978 [running]:

Additionally, bidder-params and bidder-info files are missing. These are required files.

Refer https://github.com/prebid/prebid-server/blob/225e31e9afea25f8b844adcd3d274e8db3f7135e/static/bidder-params/appnexus.json#L1-L134 and https://github.com/prebid/prebid-server/blob/06ac44bbca993745ffd4158c40f9042430fcbde2/static/bidder-info/appnexus.yaml#L1-L21 as examples

Feb 08 '24 12:02 onkarvhanumante

@bruno-siira should create docs PR in https://github.com/prebid/prebid.github.io repo. This PR is needed for include ResetDigital on prebid server docs - https://prebid.org/product-suite/prebid-server/

Additionally, refer https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#prebid-server---new-bid-adapter-go for guidelines to add new adapter in PBS-GO repo

Feb 08 '24 12:02 onkarvhanumante

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 125124bf99717139c07a02a96e5f78cb2df0b701

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.8%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:258:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:265:	getBidType		28.6%
total:										(statements)		75.5%

Feb 09 '24 10:02 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, fe4ff396d96f2e0326e2208a00f2e552ea9db079

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.8%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:258:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:265:	getBidType		28.6%
total:										(statements)		75.5%

Feb 13 '24 10:02 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 0b443846463fbbc2542201b40ebd963d1f377ff6

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.8%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:258:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:265:	getBidType		28.6%
total:										(statements)		75.5%

Feb 21 '24 10:02 github-actions[bot]

@bruno-siira

PR tests are failing. Should push change to fix
server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990)
--- FAIL: TestNewExchange (0.01s)
    exchange_test.go:89: NewExchange produced an Exchange without bidder resetdigital
E0207 18:20:15.140596   34687 exchange.go:817] OpenRTB auction recovered panic from Bidder appnexus: panic!. Account id: test1, All Bidders: bidder1,bidder2, Stack trace is: goroutine 978 [running]:
Additionally, bidder-params and bidder-info files are missing. These are required files.

Refer

https://github.com/prebid/prebid-server/blob/225e31e9afea25f8b844adcd3d274e8db3f7135e/static/bidder-params/appnexus.json#L1-L134

and https://github.com/prebid/prebid-server/blob/06ac44bbca993745ffd4158c40f9042430fcbde2/static/bidder-info/appnexus.yaml#L1-L21

as examples

@bruno-siira Please add bidder-params and bidder-info files. Refer examples provided above.

Feb 21 '24 10:02 Sonali-More-Xandr

@bruno-siira ple

@bruno-siira

PR tests are failing. Should push change to fix
server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990)
--- FAIL: TestNewExchange (0.01s)
    exchange_test.go:89: NewExchange produced an Exchange without bidder resetdigital
E0207 18:20:15.140596   34687 exchange.go:817] OpenRTB auction recovered panic from Bidder appnexus: panic!. Account id: test1, All Bidders: bidder1,bidder2, Stack trace is: goroutine 978 [running]:
Additionally, bidder-params and bidder-info files are missing. These are required files.

Refer

https://github.com/prebid/prebid-server/blob/225e31e9afea25f8b844adcd3d274e8db3f7135e/static/bidder-params/appnexus.json#L1-L134

and https://github.com/prebid/prebid-server/blob/06ac44bbca993745ffd4158c40f9042430fcbde2/static/bidder-info/appnexus.yaml#L1-L21

as examples

@bruno-siira PTAL at above comment to fix failing test case

Feb 26 '24 10:02 onkarvhanumante

@bruno-siira ple
@bruno-siira PR tests are failing. Should push change to fix
server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990)
--- FAIL: TestNewExchange (0.01s)
    exchange_test.go:89: NewExchange produced an Exchange without bidder resetdigital
E0207 18:20:15.140596   34687 exchange.go:817] OpenRTB auction recovered panic from Bidder appnexus: panic!. Account id: test1, All Bidders: bidder1,bidder2, Stack trace is: goroutine 978 [running]:
Additionally, bidder-params and bidder-info files are missing. These are required files. Refer https://github.com/prebid/prebid-server/blob/225e31e9afea25f8b844adcd3d274e8db3f7135e/static/bidder-params/appnexus.json#L1-L134

and https://github.com/prebid/prebid-server/blob/06ac44bbca993745ffd4158c40f9042430fcbde2/static/bidder-info/appnexus.yaml#L1-L21

as examples
@bruno-siira PTAL at above comment to fix failing test case

Hello,

Were trying to push today a new fix, this is blocked on the auto test from the main, I'll check that link you sent.

Feb 26 '24 11:02 bruno-siira

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 0775c721757051a216ddedf60745d481b1a4e4cb

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:257:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:264:	getBidType		28.6%
total:										(statements)		74.2%

Feb 26 '24 19:02 github-actions[bot]

@bruno-siira ple
@bruno-siira PR tests are failing. Should push change to fix
server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990)
--- FAIL: TestNewExchange (0.01s)
    exchange_test.go:89: NewExchange produced an Exchange without bidder resetdigital
E0207 18:20:15.140596   34687 exchange.go:817] OpenRTB auction recovered panic from Bidder appnexus: panic!. Account id: test1, All Bidders: bidder1,bidder2, Stack trace is: goroutine 978 [running]:
Additionally, bidder-params and bidder-info files are missing. These are required files. Refer https://github.com/prebid/prebid-server/blob/225e31e9afea25f8b844adcd3d274e8db3f7135e/static/bidder-params/appnexus.json#L1-L134

and https://github.com/prebid/prebid-server/blob/06ac44bbca993745ffd4158c40f9042430fcbde2/static/bidder-info/appnexus.yaml#L1-L21

as examples
@bruno-siira PTAL at above comment to fix failing test case
Hello,

Were trying to push today a new fix, this is blocked on the auto test from the main, I'll check that link you sent.

Still on, this commit was just to prepare the next series with the lastest merge. Is there any known problem on the Multiple Currency test with multiple headers beeing sent error @onkarvhanumante ?

Feb 27 '24 10:02 bruno-siira

@bruno-siira ple
@bruno-siira PR tests are failing. Should push change to fix
server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990)
--- FAIL: TestNewExchange (0.01s)
    exchange_test.go:89: NewExchange produced an Exchange without bidder resetdigital
E0207 18:20:15.140596   34687 exchange.go:817] OpenRTB auction recovered panic from Bidder appnexus: panic!. Account id: test1, All Bidders: bidder1,bidder2, Stack trace is: goroutine 978 [running]:
Additionally, bidder-params and bidder-info files are missing. These are required files. Refer https://github.com/prebid/prebid-server/blob/225e31e9afea25f8b844adcd3d274e8db3f7135e/static/bidder-params/appnexus.json#L1-L134

and https://github.com/prebid/prebid-server/blob/06ac44bbca993745ffd4158c40f9042430fcbde2/static/bidder-info/appnexus.yaml#L1-L21

as examples
@bruno-siira PTAL at above comment to fix failing test case
Hello, Were trying to push today a new fix, this is blocked on the auto test from the main, I'll check that link you sent.
Still on, this commit was just to prepare the next series with the lastest merge. Is there any known problem on the Multiple Currency test with multiple headers beeing sent error @onkarvhanumante ?

@bruno-siira as mentioned earlier, bidder-params and bidder-info files are missing. These are required files.

Refer https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#prebid-server---new-bid-adapter-go for guidelines to add new adapter in PBS-GO repo

Feb 28 '24 05:02 onkarvhanumante

@bruno-siira ple
@bruno-siira PR tests are failing. Should push change to fix
server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990)
--- FAIL: TestNewExchange (0.01s)
    exchange_test.go:89: NewExchange produced an Exchange without bidder resetdigital
E0207 18:20:15.140596   34687 exchange.go:817] OpenRTB auction recovered panic from Bidder appnexus: panic!. Account id: test1, All Bidders: bidder1,bidder2, Stack trace is: goroutine 978 [running]:
Additionally, bidder-params and bidder-info files are missing. These are required files. Refer https://github.com/prebid/prebid-server/blob/225e31e9afea25f8b844adcd3d274e8db3f7135e/static/bidder-params/appnexus.json#L1-L134

and https://github.com/prebid/prebid-server/blob/06ac44bbca993745ffd4158c40f9042430fcbde2/static/bidder-info/appnexus.yaml#L1-L21

as examples
@bruno-siira PTAL at above comment to fix failing test case
Hello, Were trying to push today a new fix, this is blocked on the auto test from the main, I'll check that link you sent.
Still on, this commit was just to prepare the next series with the lastest merge. Is there any known problem on the Multiple Currency test with multiple headers beeing sent error @onkarvhanumante ?
@bruno-siira as mentioned earlier, bidder-params and bidder-info files are missing. These are required files.

Refer https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#prebid-server---new-bid-adapter-go for guidelines to add new adapter in PBS-GO repo

Hello @onkarvhanumante ,

I'll add these files in next commit, they're prepared but I'd not added to not confuse the bigger problem, anyway they're on the way.

On the main note, where I need help, I got the error that is on the process above, on running locally the test TestExtraBidWithMultiCurrencies, of bidder_test.go, at this intruction:

	mockedHTTPServer := httptest.NewServer(http.HandlerFunc(
		func(rw http.ResponseWriter, req *http.Request) {
			rw.Write([]byte(`{"dataAsOf":"2022-11-24T00:00:00.000Z","generatedAt":"2022-11-24T15:00:46.363Z","conversions":{"USD":{"USD":1,"INR":81.65706328627678}}}`))
			rw.WriteHeader(http.StatusOK)
		}),
	)

the error is the one below:

http: superfluous response.WriteHeader call from github.com/prebid/prebid-server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990)

I don't call any write headers on my code, so I'm a lot of confuse. Can I get any help?

Feb 28 '24 10:02 bruno-siira

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 33f46030341d4eede74339059952d7766bca0bbb

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:257:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:264:	getBidType		28.6%
total:										(statements)		74.2%

Feb 28 '24 10:02 github-actions[bot]

@bruno-siira ple
@bruno-siira PR tests are failing. Should push change to fix
server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990)
--- FAIL: TestNewExchange (0.01s)
    exchange_test.go:89: NewExchange produced an Exchange without bidder resetdigital
E0207 18:20:15.140596   34687 exchange.go:817] OpenRTB auction recovered panic from Bidder appnexus: panic!. Account id: test1, All Bidders: bidder1,bidder2, Stack trace is: goroutine 978 [running]:
Additionally, bidder-params and bidder-info files are missing. These are required files. Refer https://github.com/prebid/prebid-server/blob/225e31e9afea25f8b844adcd3d274e8db3f7135e/static/bidder-params/appnexus.json#L1-L134

and https://github.com/prebid/prebid-server/blob/06ac44bbca993745ffd4158c40f9042430fcbde2/static/bidder-info/appnexus.yaml#L1-L21

as examples
@bruno-siira PTAL at above comment to fix failing test case
Hello, Were trying to push today a new fix, this is blocked on the auto test from the main, I'll check that link you sent.
Still on, this commit was just to prepare the next series with the lastest merge. Is there any known problem on the Multiple Currency test with multiple headers beeing sent error @onkarvhanumante ?
@bruno-siira as mentioned earlier, bidder-params and bidder-info files are missing. These are required files. Refer https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#prebid-server---new-bid-adapter-go for guidelines to add new adapter in PBS-GO repo
Hello @onkarvhanumante ,

I'll add these files in next commit, they're prepared but I'd not added to not confuse the bigger problem, anyway they're on the way.

On the main note, where I need help, I got the error that is on the process above, on running locally the test TestExtraBidWithMultiCurrencies, of bidder_test.go, at this intruction:
	mockedHTTPServer := httptest.NewServer(http.HandlerFunc(
		func(rw http.ResponseWriter, req *http.Request) {
			rw.Write([]byte(`{"dataAsOf":"2022-11-24T00:00:00.000Z","generatedAt":"2022-11-24T15:00:46.363Z","conversions":{"USD":{"USD":1,"INR":81.65706328627678}}}`))
			rw.WriteHeader(http.StatusOK)
		}),
	)
the error is the one below:

http: superfluous response.WriteHeader call from github.com/prebid/prebid-server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990)

I don't call any write headers on my code, so I'm a lot of confuse. Can I get any help?

@bruno-siira tests are failing because ResetDigital adapter is not registered. Test log clearly states [resetdigital: builder not registered]

Refer https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html for details on introducing new adapter.

Refer https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#register-with-the-core to resolve test error

2024/02/28 12:49:13 http: superfluous response.WriteHeader call from github.com/prebid/prebid-server/v2/exchange.TestExtraBidWithMultiCurrencies.func1 (bidder_test.go:2990)
--- FAIL: TestNewExchange (0.01s)
    exchange_test.go:74: Error intializing adapters: [resetdigital: builder not registered]
--- FAIL: TestGetBidCacheInfoEndToEnd (0.01s)
    exchange_test.go:1226: Error intializing adapters: [resetdigital: builder not registered]

Feb 29 '24 05:02 onkarvhanumante

@bruno-siira Requesting you to please address the open comments.

Mar 10 '24 16:03 gargcreation1992

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, e46821734393220bd664249f2ab38c3d97305431

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:257:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:264:	getBidType		28.6%
total:										(statements)		74.2%

Mar 17 '24 10:03 github-actions[bot]

@bruno-siira tests are failing because ResetDigital adapter is not registered. Test log clearly states [resetdigital: builder not registered]

Sorry, I misunderstood the problem. Where should I register the builder. Do you have some example of implementation?

Mar 17 '24 10:03 bruno-siira

@bruno-siira tests are failing because ResetDigital adapter is not registered. Test log clearly states [resetdigital: builder not registered]

Sorry, I misunderstood the problem. Where should I register the builder. Do you have some example of implementation?

Refer https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#register-with-the-core

Mar 18 '24 11:03 onkarvhanumante

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, b8ca566e383e9e356ae601201cc6eb13f3d8bb1c

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:56:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:73:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:81:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:89:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:97:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:138:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:173:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:209:	getBidFromResponse	93.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:244:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:251:	getBidType		28.6%
total:										(statements)		78.3%

Mar 18 '24 18:03 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2de778168962de80a39c981d2d16563245d57f60

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:257:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:264:	getBidType		28.6%
total:										(statements)		74.2%

Mar 24 '24 19:03 github-actions[bot]

@bruno-siira PR is failing due to following reasons

Running go vet check
# github.com/prebid/prebid-server/v2/openrtb_ext
Error: openrtb_ext/imp_resetdigital.go:4:2: struct field cid has json tag but is not exported
Error: openrtb_ext/imp_resetdigital.go:5:2: struct field crid has json tag but is not exported
Error: openrtb_ext/imp_resetdigital.go:6:2: struct field adid has json tag but is not exported

Mar 26 '24 12:03 onkarvhanumante

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, eb067f7a7ceb5693937adb814602e70c1c3647a8

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:257:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:264:	getBidType		28.6%
total:										(statements)		74.2%

Mar 26 '24 21:03 github-actions[bot]

@bruno-siira PR has few unaddressed comments. PTAL

May 02 '24 07:05 onkarvhanumante

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 86206d77932ebfc20779398a9f3dd999fc1d7cd6

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:257:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:264:	getBidType		28.6%
total:										(statements)		74.2%

May 06 '24 17:05 github-actions[bot]

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 3fc545596d2bd09e44b43f0f3a69cce3150a4c2b

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:57:	Builder			0.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:69:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:86:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:94:	getReferer		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:102:	getCurrency		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:110:	MakeRequests		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:151:	processDataFromRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:186:	MakeBids		72.2%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:222:	getBidFromResponse	93.3%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:257:	getBidPrice		66.7%
github.com/prebid/prebid-server/v2/adapters/resetdigital/resetdigital.go:264:	getBidType		28.6%
total:										(statements)		74.2%

May 14 '24 17:05 github-actions[bot]

https://github.com/prebid/prebid-server/pull/3452/files#r1553471267
https://github.com/prebid/prebid-server/pull/3452/files#r1553490761
https://github.com/prebid/prebid-server/pull/3452/files#r1553659997
https://github.com/prebid/prebid-server/pull/3452/files#r1553664849
https://github.com/prebid/prebid-server/pull/3452/files#r1553666487
https://github.com/prebid/prebid-server/pull/3452/files#r1553674609
https://github.com/prebid/prebid-server/pull/3452/files#r1553684914
https://github.com/prebid/prebid-server/pull/3452/files#r1553688982
https://github.com/prebid/prebid-server/pull/3452/files#r1553696154
https://github.com/prebid/prebid-server/pull/3452/files#r1553711184
https://github.com/prebid/prebid-server/pull/3452/files#r1478680728
https://github.com/prebid/prebid-server/pull/3452/files#r1482915519
https://github.com/prebid/prebid-server/pull/3452/files#r1612700678
https://github.com/prebid/prebid-server/pull/3452/files#r1553486214

@bruno-siira requesting to resolve above comments

May 24 '24 03:05 onkarvhanumante

@bruno-siira closing this PR. You can open PR after addressing the open comments

Jun 11 '24 04:06 onkarvhanumante