Wei Wang

Results 259 comments of Wei Wang

+1 for eliminating the extension verifying. It is not necessary or a good reason to use the extension to determine whether the file can be opened or not. My situation...

@muratyilmaz Thanks for it. LGTM. But can you revert the changes to `Main.storyboard`? It seems there are only rect changes but it contains [an ambiguous](https://github.com/onevcat/APNGKit/pull/113/files#diff-3ac05ec234c3645b124b8abada55dd0fd2e467f9cf6f4c0e68fc188db0463439R620) which I do not quite...

APNGKit v2 was just released but it still renders the content directly on layer, so this is not supported now. But it should be easy enough to support and I...

I myself never saw this before. Since the crash is happening inside SwiftUI, now I am not sure if it can be fixed or have a workaround with Kingfisher. Does...

@phedlund Seems I cannot reproduce it. Am I doing the right thing? Or can you paste some code snippet which we can use to reproduce it? ![截屏2022-02-07 11 30 00](https://user-images.githubusercontent.com/1019875/152715462-ccbbbd96-e565-4298-8c67-c596eab1d028.png)...

According to the initial report in this post, the crash happens inside iOS and due to `CGImageGetImageSource` and `CFDataGetBytes`. I cannot reproduce it myself now, so it is not obvious...

@MalcolmnDEV Thanks for the information. May I know if you have any information about the displayed GIF file? Is it a user generated one or an image you created and...

@MalcolmnDEV No..The original `CFDataGetBytes` issue is still a mystery. Is it only on iOS 15 or also iOS 14? According to current reports it seems only on iOS 15, can...

Ummm. Maybe related to this https://github.com/SDWebImage/SDWebImage/issues/3273 I will check how and whether it also affects Kingfisher.

Hmmm...Tried a bit but seems it is not the same issue with SDWebImage's crash. Unlike in SDWebImage, Kingfisher does not hold the decoder even when multiple image views are showing...