Wei Wang

Results 259 comments of Wei Wang

I will revisit this issue this weekend when I can find some more time!

Hi, I have a chance to check this issue again today, and here are some of my thoughts. 1. As we all know, from iOS 15, Apple deprecated the implicit...

Cannot reproduce it. Maybe it is an integrating error? Does linking SwiftUI strongly to your app/or to the Kingfisher target resolve this issue?

This should be already fixed in Xcode 13.2 according to its release note: > Fixed an issue that prevented Swift libraries depending on Combine from building for targets including armv7...

The type of `value` in your code is an `ImageCacheResult`. I guess you cannot set it as a parameter of `kf.setImage`, unless you have your own version. I suspect this...

@subhani-ali The stack you provided even not contains an invocation of Kingfisher. Can you confirm that it is from Kingfisher or other packages (AWSMobileClient?)

@Ankish Currently `ImagePrefetcher` is basically a simple wrapper to combine downloader and cache. I definitely agree with @krodak for the long-term solution. Instead of current data task-based session, we need...

It could be an improvement and I will try to add it later.

Maybe again related to this Apple bug (https://github.com/onevcat/Kingfisher/issues/1717). Seems that the `objectWillSend` is not working well before iOS 13.3.

A [new commit](https://github.com/onevcat/Kingfisher/commit/d0494dd78f7adf2d3526fdf3267176553020c041) was just appended to the `version6-xcode13` branch. @kangnux Can you help to verify and check how it works with that change? Thanks!