Kingfisher icon indicating copy to clipboard operation
Kingfisher copied to clipboard

KFImage.renderingMode(.original) not working as expected.

Open phedlund opened this issue 4 years ago • 1 comments

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

Issue Description

What

It's my understanding that adding .renderingMode(.original) to a KFImage should remove the highlight effect when used inside a NavigationLink. I still see the highlight flicker. Using .buttonStyle(.plain) on Text views works fine for removing the highlight.

Reproduce

Add a few HStack with a KFImage().renderingMode(.original) and a Text("Title").buttonStyle(.plain) inside a LazyVStack. The HStacks should be wrapped in NavigationLink.

The images will have highlight effects but the texts will not.

Other Comment

[Add anything else here]

phedlund avatar Jan 26 '22 02:01 phedlund

@phedlund

Seems I cannot reproduce it. Am I doing the right thing? Or can you paste some code snippet which we can use to reproduce it?

截屏2022-02-07 11 30 00

And if I remembered correctly, the default behavior of an image/text/button in the navigation link was changing all the versions from iOS 13 to 15. The screenshot above was taken in iOS 15. So if you are trying another version of iOS, it is also grateful if you can mention it too.

onevcat avatar Feb 07 '22 02:02 onevcat