onejimmyboy

Results 9 comments of onejimmyboy

> IMO, it's not necessary to generate pop retry on startup. When retry message revives, pop retry topic will be create automaticazidong 自动生成的是:MixAll.RETRY_GROUP_TOPIC_PREFIX + cid + "_" + topic;不满足有些方法的需求 public...

@RongtongJin @ShannonDing Hi, could you please review this pr? Thanks a lot :)

> It seems that it is not appropriate to create retry topic in PopMessageProcessor. > > For the background, the retry topic will be created when heartbeat request is sent...

> I personally think that you should modify the code of the dashboard instead of modifying the broker to add this topic. This topic is unnecessary. The dashboard has not...

这个已经做好了吗?有mr吗?近期也打算开始改造这部分

> > 这个已经做好了吗?有mr吗?近期也打算开始改造这部分 > > 我们线上在跑一段时间了,我尽快安排 PR 赞,希望能够尽快pr哈,以便我们可以能尽快适配测试。

> > 这个已经做好了吗?有mr吗?近期也打算开始改造这部分 > > 我们线上在跑一段时间了,我尽快安排 PR hello,我看这个mr还没有提交,打算啥时候提交类