rocketmq
rocketmq copied to clipboard
[ISSUE #7478] On startup, if not check crc, not read message body. avoid startup too slow when data is large
Which Issue(s) This PR Fixes
Fixes #7478
Brief Description
see issue #7478
How Did You Test This Change?
tens of minuts reduced to about 1 minuts
Codecov Report
Merging #7479 (cd0ab8d) into develop (f0f15b5) will increase coverage by
0.03%
. Report is 1 commits behind head on develop. The diff coverage is42.85%
.
@@ Coverage Diff @@
## develop #7479 +/- ##
=============================================
+ Coverage 42.93% 42.97% +0.03%
- Complexity 9660 9669 +9
=============================================
Files 1161 1161
Lines 83930 83934 +4
Branches 10898 10899 +1
=============================================
+ Hits 36038 36072 +34
+ Misses 43410 43389 -21
+ Partials 4482 4473 -9
Files | Coverage Δ | |
---|---|---|
...che/rocketmq/acl/plain/PlainPermissionManager.java | 77.56% <0.00%> (-0.82%) |
:arrow_down: |
...main/java/org/apache/rocketmq/store/CommitLog.java | 57.85% <50.00%> (-0.03%) |
:arrow_down: |
... and 20 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Failed tests seem unrelated.
If you don't read the message file, will there be other impacts
If you don't read the message file, will there be other impacts
if not check CRC, nothing is done to the readed body, so read or not read is the same