Curtis Vogt comments

Results 388 comments of


                                            Curtis Vogt

Enable ZonedDateTime to parse its own string representation

> As far as I can tell, `DateTime` from the `Dates` standard library is always able to parse its own output and in my opinion, it would be nice if...

Escape special chars in username/password to avoid building incorrect URIs

Change looks good to me. Could use some tests though

Improve re-compilation for future ZonedDateTime beyond 2038

Thanks for reporting this. It looks like some of the TZJFile revisions that happened a while ago broke this code path.

move from CLDR artifact to code generation

Sorry, I've been rather swamped lately. I only have one major concern with this approach and is that each time there is a CLDR release we need to update TimeZones.jl....

Differences in `Base.Iterators.map` and `IterTools.imap`

I was going to suggest adding `Iterators.map` to [Compat.jl](https://github.com/JuliaLang/Compat.jl) but `Iterators.map` has existed since Julia 1.6 so it doesn't seem worth it

Minimize allocations when unpacking `TimeZone`s from cache

I'll try to take a look soon. I'll call out that I also want to get #382 merged soon as well.

Minimize allocations when unpacking `TimeZone`s from cache

I've been a bit swamped this week. Overall, I'm in favour of this change and will definitely merge this before #382

Minimize allocations when unpacking `TimeZone`s from cache

It turned out #382 became urgent to merge for Julia 1.9 so the original plan had changed. If @nickrobinson251 you have time to rebase this against the latest version of...

Minimize allocations when unpacking `TimeZone`s from cache

Superseded by #451

Reduce overhead running with Mocking activated but no patches applied

> I wonder if we can reduce this overhead? I'm onboard with this. We definitely should create some benchmarks to measure this that we can test over time to avoid...