Curtis Vogt

Results 388 comments of Curtis Vogt

I'm planning on rolling some other changes in before making a release here. I expect TimeZones.jl 1.17 should be out by 2024-05-27 (Monday).

I originally added this accessor code when Dates.jl narrowed the types used for these sub-day accessors: https://github.com/JuliaTime/TimeZones.jl/commit/61d8299a50a54cb3e194dc3e27ce851deca5edd2.

In looking over the code again I realized that part of the original implementation was avoiding defining additional methods where they weren't required. Defining methods for `year`, `month`, etc. aren't...

Looks like I'll be dealing with LTS issues before getting this in. Update: CI WeakDeps failure was just a fluke

So [`ind2chr`](https://docs.julialang.org/en/v0.6/stdlib/strings/#Base.ind2chr) and [`chr2ind`](https://docs.julialang.org/en/v0.6/stdlib/strings/#Base.chr2ind) were deprecated way back in Julia 0.7: > - `sub2ind` and `ind2sub` are deprecated in favor of using `CartesianIndices` and `LinearIndices` (https://github.com/JuliaLang/julia/issues/24715). Looks like this code...

Thanks. Could use some revision but I can see why having a more trivial example is useful

I've updated the documentation to use Documenter instead of just the README. If you feel like this example is still useful feel free to re-open this PR with these changes...

Sorry about this disruptive change. Typically the tzdata updates are rather minor but this [latest one changed more than I realized](https://data.iana.org/time-zones/tzdb-2022f/backward). I'll try to add some tests to catch these...

> Is there any functional difference between `TimeZone("Europe/Stockholm", TimeZones.Class(:LEGACY))` and `TimeZone("CET")`...? It's just easier for me to solve this by swapping "Europe/Stockholm" with "CET"... Historically there is a different between...

This was fixed in https://github.com/JuliaTesting/Mocking.jl/pull/113 and included in v0.7.8 Example: ```julia julia> using Mocking: @patch julia> f() = 5 f (generic function with 1 method) julia> f_patch = @patch f()...