Curtis Vogt
Curtis Vogt
We did the experiment with Cassette some time ago at this point but unfortunately there was too much of a performance reduction in comparison to using the `@mock` macro: https://github.com/JuliaTesting/Mocking.jl/issues/53#issuecomment-572204715
This is because `escape_string(s; keep=('"',))` is actually `escape_string(s, ('"',); keep=('"',))` and the `esc` argument takes precedence over `keep`. You can work around this via: ```julia julia> escape_string(s, (); keep=('"',)) "\""...
> @omus it turns out you don't actually need to add it to keep at all True. I thought it was clearer to include `"` in `keep` in addition to...
Not sure what's going on with the CI test failures. I see there's an interactive username prompt which seems to be failing the Pkg.jl tests. I haven't been able to...
You can just use `TimeZones.build` and pass in a tzdata version: ```julia julia> TimeZones.build("2016a") [ Info: Installing 2016a tzdata region data [ Info: Converting tz source files into TimeZone data...
I think we should support `UTC` in TimeZones.jl but I'm doubtful we can make `UTC === tz"UTC"` but we should at least make them `==`.
The hold up here is that `UTC` is currently a singleton instance which is only ever used as a type in `now`. It may be good to change that type...
The definition of the `TimeZone` abstract type in Dates.jl pre-dates Julia 0.4. Possibly the intent was to roll time zone support into Dates.jl but I'm not fully sure. I'm curious...
Something else that's weird about this is that it appears we clone the entire registry first before we check if it's already present. Seems like we could see a performance...
The README.md will need to have the https://ssfrr.github.io/DeepDiffs.jl/images/multistringdiff.png image updated