omrishiv

Results 17 comments of omrishiv
trafficstars

@xauthulei Thank you, working on it with the org

I've spent the last few days addressing this problem myself, and I'd like to offer up what I did as a workaround: I have to use a Github app to...

I second this. I'm going to try and take a look at how easy this is to do myself

I think this is fixed in main: https://github.com/ray-project/ray/blob/master/python/ray/autoscaler/_private/command_runner.py#L352

Thanks for the quick review; I added the tests

Hi @werne2j do the tests look ok?

I added the fixtures to test and caught a case where `:` wasn't being templated. Now it should be

@werne2j gentle nudge if this looks good. Thanks!

@werne2j bumping again please

I actually managed to work around this by using a nested secret, but still curious if there's actually a reason this is restricted