argocd-vault-plugin icon indicating copy to clipboard operation
argocd-vault-plugin copied to clipboard

Published 20 hours ago • verified publisher icon argoproj-labs

unrestrict remove-missing from configmap and secret

Open omrishiv opened this issue 1 year ago • 2 comments

Is your feature request related to a problem? Please describe. Is there a reason that the remove-missing only works on ConfigMaps and Secrets? I have a CustomResource I would love to use it on. Right now, I have jinja template a file with conditionals that then gets kustomized. If i can use remove-missing, I can have all the fields in there and remove the conditional. The lack of keys in vault would act as the conditional.

Describe the solution you'd like Remove missing should work on all resources

Describe alternatives you've considered I'm not sure how to work around this issue otherwise.

Additional context I have removed the check in util.go and can open a PR if it makes sense; it seems to do what I expect.

omrishiv avatar May 13 '23 22:05 omrishiv

I actually managed to work around this by using a nested secret, but still curious if there's actually a reason this is restricted

omrishiv avatar May 14 '23 02:05 omrishiv

Glad you found a workaround. This was the reason at the time https://github.com/argoproj-labs/argocd-vault-plugin/pull/177#issuecomment-898016968.

werne2j avatar May 14 '23 02:05 werne2j