Shohei Okumiya

Results 133 comments of Shohei Okumiya

@zabetak Updated. Thanks for reviewing this PR and giving many suggestions. I believe the change is much simpler

I rebased it again because the previous base revision was affected by HIVE-28611

Thanks. Let me pick up the first option. > Ensure that the Pull Request has a +1 vote, and that 24 hours have elapsed since the first +1 vote was...

I also think the current Hive's behavior is weird. Should we expect the current implementation to include a bug? Or can we have a valid reason to justify the current...

I personally second @zratkai 's opinion. We have three options when the CAST function meets unreasonable inputs. 1. Produce unreasonable output 2. Produce NULL 3. Let it crush I think...

One test failed on the revision = 4206c61. - https://ci.hive.apache.org/blue/rest/organizations/jenkins/pipelines/hive-precommit/branches/PR-5409/runs/6/nodes/597/log/?start=0 I think this PR should not change the behavior of ACID, and the problem is not reproduced on my local...

I modified places related to coding styles. I still keep a couple of comments untouched. That's just because I am searching my memory for my original intentions. Just a moment...

@deniskuzZ I think I applied changes for all comments and cosmetic changes suggested by Sonar cloud(such as cognitive complexity is not handled as the issue is likely to exist originally)....

@himanshu-mishra Sorry, I don't have the right to merge a PR as I am not a committer. You need approval of any committer who is ideally an expert of SMB...