Shohei Okumiya

Results 133 comments of Shohei Okumiya

@kasakrisz Thanks. I found `cbo_rp_groupby3_noskew_multi_distinct.q` fails and it turned out the root cause is not HiveAggregateReduceFunctionsRule but CBO Return Path + non-map-side aggregation. We may check the problem first. https://github.com/apache/hive/pull/5245...

Rebased & followed your comments. Waiting for CI to finish... https://github.com/apache/hive/pull/5091/commits/e78e27bc593c20a312c76b7ba9c06b96176bc647

CI passed. > as you mentioned: "I believe SUM should return NULL if all rows are evaluated as NULL" on both CBO and non-CBO path. Swapping these lines may help...

While testing various cases, I found this might not work when amounts of unified vertices are uneven. I will close this one once. https://github.com/apache/tez/blob/rel/release-0.10.3/tez-runtime-library/src/main/java/org/apache/tez/dag/library/vertexmanager/FairShuffleVertexManager.java#L443-L447

No pool is implemented yet, however, RedisClient provides transaction interfaces. So, if an thread calls RedisClient#withTransaction, another thread's calls may be also executed in its transaction. To avoid this, Should...

@okkez I have an approximate approach in a local machine. My approach abstracts a TCP channel. ```java abstract TcpChannel { boolean read(); boolean write(); } class TlsPlaintextChannel extends TcpChannel {...

Divides conversion layers and provides back-pressure between each layers. https://github.com/okumin/influent/issues/9#issuecomment-326953942

I think that NioForwardConnection with handshake support is a finite state machine, so it looks nice that `onReadable` branches into `switch (state)`. So your plan is good. In detail, -...

![influent-architecture](https://user-images.githubusercontent.com/1548925/30026938-e63adb42-91b9-11e7-9ffc-a2c32d515829.jpg)

There are three conversions. * Fluentd domain object An array of Msgpack * **One** message of Fluentd matches **one** array of msgpack * So both [encoding](https://github.com/okumin/influent/blob/master/influent-java/src/main/java/influent/forward/NioForwardConnection.java#L183-L186) and [decoding](https://github.com/okumin/influent/blob/master/influent-java/src/main/java/influent/forward/NioForwardConnection.java#L161) are too...