apache
HIVE-24167: TPC-DS query 14 fails while generating plan for the filter
What changes were proposed in this pull request?
With this change, Hive skips using or persisting runtime stats when PlanMapper throws equivalence mapping violation.
In some more contexts, we've tried to resolve the violation in #5037 and #5077. However, we couldn't find an obvious way to ideally avoid the issue, which means a modification will likely cause another problem. That's why we are currently biased toward the current approach.
https://issues.apache.org/jira/browse/HIVE-24167
Why are the changes needed?
When this issue occurs, the query always fails. We think the disadvantage of failure is not well balanced with the advantage of fast failure. A query might run with a bit poorer performance without runtime stats, but it is not critical in most cases. That's why we would try disabling runtime stats in this case.
Does this PR introduce any user-facing change?
In the new behavior, affected queries will not fail but run without runtime statistics.
Is the change a dependency upgrade?
No.
How was this patch tested?
qtests.
Quality Gate passed
Issues
5 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarCloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@zabetak Updated. Thanks for reviewing this PR and giving many suggestions. I believe the change is much simpler
I rebased it again because the previous base revision was affected by HIVE-28611
Quality Gate passed
Issues
4 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarCloud
Thanks. Let me pick up the first option.
Ensure that the Pull Request has a +1 vote, and that 24 hours have elapsed since the first +1 vote was cast on the Pull Request. Note that this rule appears in the Hive Bylaws. Do not ignore it.
Based on this rule, I will wait for 1 day and return here.