Andrew Coffey

Results 208 comments of Andrew Coffey

pygame-ce compat with weird missing dlls

Thanks. Let's move this back on topic lol. Lemme know if I should make any further changes

pygame-ce compat with weird missing dlls

I'll definitely wait until after the schema update is made to push the extra data files. If I skip the pre-commit hook, then it'll still be blocked by the schema...

pygame-ce compat with weird missing dlls

As far as I know, this should be good to go. Need a maintainer to run the CI though to see if I borked anything

pygame-ce compat with weird missing dlls

I verified locally that it worked with my reproducer

Coverage CI created, hopefully it works first time lol

That looks super interesting. I’ll look into using that when I get home

set_at now take `intptr_t` for x, y instead of int, and guards 32-bit architectures

@Starbuck5 blame Ankith on those last two comments of yours. That's what I originally had

Fix `pygame.sprite.Group.has()` behavior for no sprites given

Can you motivate this change with an example of when this change would actually matter? Offhand, I can't come up with a valid use-case where it should matter what this...

sprites now have limited support for Texture and Renderer

Sample code (provided by rethanon on discord) ```py import random import time import pygame import pygame._sdl2 as sdl2 pygame.init() WINDOW: pygame.Window = pygame.Window("Sprite Test", (800, 600)) RENDERER: sdl2.Renderer = sdl2.Renderer(WINDOW)...

sprites now have limited support for Texture and Renderer

> Just a minor nitpick but I'd like whitespace/formatting changes to be a separate PR, preferably with some way to keep it automated with changes to our precommit config Same...

sprites now have limited support for Texture and Renderer

Also, I have absolutely no idea why this pull is causing segfaults