omar

Results 2356 comments of omar

There is no error in the code you posted above. You can update to get the 2 fixes I pushed already. The issue in (3) could separately be improved but...

> There are errors in my code. Sorry maybe you read email notification for my first message (which I deleted now, it was a draft before I realized the culprit...

I am not sure what solution you would suggest here? Problem stem from the fact that `BeginChild` construct a string to pass to `Begin` which will hash it. If `BeginChild`...

Note that you can also use `BeginChild(ImU32 id)` with our own id which would also ease fixing the problem on your side. > Just an idea, maybe we can put...

> We could add a strcmp() assert in the success path of FindWindowByName(). Ah no, that's actually stupid :( it would defeat the whole purpose of `###` when changing the...

> Is it useful in any way to have ### in children? Maybe we can assert when there is ### in the child. Never required, since child name are never...

(I tagged this issue with commit only because the topics are similar but the issue discussed here is still valid.)

I've been looking at this problem today as part of another set of of issues. Recap: `###` is not meaningful in `BeginChild()` context. but ideally should not result in that...

> Because for labelled windows I have to pass "###World", while for windows where label == id I have to pass "World", which is pretty counter-intuitive and dirty. So +1...

I am also expecting that some usage pattern for renaming table columns while preserving columns data (#9108) may benefit from this change which I am currently testing.